[FLINK-39977][runtime] Recovery of merged channel state handles - #29043
Conversation
Generated-by: OpenAI Codex (GPT-5.6 Sol)
|
@1996fanrui Would you please take a look? |
1996fanrui
left a comment
There was a problem hiding this comment.
Hey @Zakelly , thanks for the pr! I will take a look next week
1996fanrui
left a comment
There was a problem hiding this comment.
Thanks @Zakelly for the fix, lgtm
The fix is simple than I expected
|
@1996fanrui Yeah, it's also beyond my imagine :D. Thanks for the review |
|
@Zakelly , @1996fanrui P.S.: there are more failures |
|
also looking at master CI |
What is the purpose of the change
This pull request fixes recovery from checkpoints containing channel state written by the unified file-merging mechanism.
During recovery, the file-merging snapshot manager previously restored keyed and operator state handles but ignored channel state handles. Consequently, merged files referenced by input channel state, upstream output buffer state, or result subpartition state were not restored into the file-merging snapshot manager's tracking information.
Brief change log
FileMergingChannelStateITCaseto verify recovery after replacing all TaskManagers.Verifying this change
This change added and extended tests and can be verified as follows:
FileMergingChannelStateITCase, which:SegmentFileStateHandle.FileMergingSnapshotManagerTestBaseto verify that input channel, upstream output buffer, and result subpartition state handles are restored and tracked without duplicating shared delegates.FileMergingChannelStateITCasesuccessfully; it completed in approximately 22 seconds locally.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex (GPT-5.6 Sol)