Repository navigation
Conversation
|
🎊 +1 overall
This message was automatically generated. |
riya2305
force-pushed
the
MAPREDUCE-fix-am-tracking-url
branch
from
September 10, 2026 05:57
dfea637 to
6b4f941
Compare
Hean-Chhinling
approved these changes
Sep 10, 2026
Hean-Chhinling
left a comment
Hean-Chhinling
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch @riya2305!
LGTM!
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@slfan1989 can you please review and merge this, thanks. |
Hean-Chhinling
suggested changes
Sep 11, 2026
Hean-Chhinling
left a comment
Hean-Chhinling
left a comment
Contributor
There was a problem hiding this comment.
After looking at it more closer, I could some flaws on this PR.
- Shouldn't the test be at
TestAMWebApp.javainstead ofTestProxyUriUtils.java? - I think the ticket shall be at MAPREDUCE project instead of HADOOP.
- I found a similar changes before here. Shall it be linked with each other? https://issues.apache.org/jira/browse/MAPREDUCE-7533
And it would be nice to explain what was wrong with MAPREDUCE-7533 that why this PR is needed.
slfan1989
reviewed
Sep 24, 2026
|
|
||
|
|
||
| @Test | ||
| void testGetProxyUriWithWebAppPath() throws Exception { |
Contributor
There was a problem hiding this comment.
Thanks for the fix. Could we add a regression test in TestAMWebApp that exercises the actual redirect and route changes?
The new test only checks ProxyUriUtils.getProxyUri(), which is unchanged and already supports URLs containing paths. It would still pass if both changes to AMWebApp were reverted, so it does not protect against the reported 404 regression.
Please start the AM WebApp and verify that:
- Requesting
/redirects to/mapreduce/app. - Following the redirect returns HTTP 200 with the expected application page
content.
Please also ensure the test cleans up both the client service and the MRApp in a finally block.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
On the YARN UI clicking on the application tracking URL results in 404; Appending /mapreduce/app at the end of URL will render to the correct page.
How was this patch tested?
tested patch manually
For code changes:
declared according to the connector-specific documentation? Note: Automated CI
testing doesn't cover all cases so manual testing with cloud storage is still
required.
LICENSE,LICENSE-binary,NOTICE-binaryfiles?