Skip to content

HIVE-27991: Utilise FanoutWriters when inserting records in an Iceberg table when the records are unsorted - #4988

Merged
SourabhBadhya merged 1 commit into
apache:masterfrom
SourabhBadhya:HIVE-27991
Jan 22, 2024
Merged

SourabhBadhya merged 1 commit into
apache:masterfrom
SourabhBadhya:HIVE-27991

Conversation

@SourabhBadhya

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Utilise FanoutWriters when inserting records in an Iceberg table when the records are unsorted

Why are the changes needed?

FanoutWriter is a writer in Iceberg which can be used to write records in a table. This writer keeps all the file handles open, until the write is finished. FanoutWriters is used as the writer when the incoming records are unsorted. We can by default have some mechanism to switch to using FanoutWriters instead of ClusteredWriters when custom sort expressions are not present for the given table/query.
Similar stuff is already implemented in Spark - apache/iceberg#8621

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

QTests

@zhangbutao zhangbutao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SourabhBadhya
SourabhBadhya merged commit 1aeaff2 into apache:master Jan 22, 2024
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Feb 9, 2024
…g table when the records are unsorted (apache#4988) (Sourabh Badhya reviewed by Butao Zhang)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Mar 7, 2024
…g table when the records are unsorted (apache#4988) (Sourabh Badhya reviewed by Butao Zhang)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants