Skip to content

http2: Log header limit violations only once - #666

Closed
mkauf wants to merge 1 commit into
apache:trunkfrom
mkauf:http2_log_header_limit_violations_once
Closed

mkauf wants to merge 1 commit into
apache:trunkfrom
mkauf:http2_log_header_limit_violations_once

Conversation

@mkauf

@mkauf mkauf commented Jun 5, 2026

Copy link
Copy Markdown

The previous fix in icing/mod_h2#181 does not work anymore.

The previous fix in icing/mod_h2#181 does not work
anymore.
@notroj

notroj commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

@mkauf all your patches are obviously correct, please accept the standing invitation to commit rights so you can merge yourself.

notroj added a commit to notroj/httpd that referenced this pull request Oct 31, 2026
mod_http2: log request header limit violations only once per stream.

* modules/http2/h2_stream.c (h2_stream_add_header): Guard the AH10178,
  AH10180 and AH10181 log messages on stream->request_headers_failed
  rather than h2_stream_is_ready().
  (h2_stream_end_headers): Likewise for AH10230.

Submitted by: Michael Kaufmann <mail michael-kaufmann.ch>

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GitHub: closes apache#765, closes apache#666


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1938328 13f79535-47bb-0310-9956-ffa450edef68

(cherry picked from commit 6340a31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants