Repository navigation
Fix Redis read/write timeout units - #790
Closed
arturobernalg wants to merge 1 commit into
Closed
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
PR: 70193 Based on the patch by Christophe JAILLET in Bugzilla attachment 40212.
arturobernalg
force-pushed
the
fix/httpd-70193-redis-timeout-units
branch
from
October 6, 2026 18:04
8c522da to
186d37c
Compare
Collaborator
|
Thanks, again, nice PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mod_socache_redis passes RedisTimeout to apr_redis_server_create() in
microseconds, while the APR API expects whole seconds. As a result the
timeout was effectively infinite.
Convert to seconds when creating the server, rounding up so that a
positive timeout never becomes 0.
PR 70193