Skip to content

chore(apache): add apache license checker for CI - #2009

Closed
dongzl wants to merge 9 commits into
apache:masterfrom
dongzl:license-checker
Closed

chore(apache): add apache license checker for CI#2009
dongzl wants to merge 9 commits into
apache:masterfrom
dongzl:license-checker

Conversation

@dongzl

@dongzl dongzl commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Nov 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2009 (7563111) into master (7acd496) will increase coverage by 1.57%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2009      +/-   ##
============================================
+ Coverage     62.38%   63.96%   +1.57%     
+ Complexity      978      675     -303     
============================================
  Files           482      482              
  Lines         41463    41463              
  Branches       5890     5890              
============================================
+ Hits          25868    26523     +655     
+ Misses        13047    12299     -748     
- Partials       2548     2641      +93     
Impacted Files Coverage Δ
...egraph/backend/store/hbase/HbaseStoreProvider.java 0.00% <0.00%> (-100.00%) ⬇️
...hugegraph/backend/store/hbase/HbaseSerializer.java 0.00% <0.00%> (-92.31%) ⬇️
...idu/hugegraph/backend/store/hbase/HbaseTables.java 0.00% <0.00%> (-89.86%) ⬇️
...du/hugegraph/backend/store/hbase/HbaseMetrics.java 0.00% <0.00%> (-86.96%) ⬇️
...raph/backend/store/cassandra/CassandraMetrics.java 0.00% <0.00%> (-85.04%) ⬇️
...u/hugegraph/backend/store/hbase/HbaseFeatures.java 0.00% <0.00%> (-83.34%) ⬇️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 0.00% <0.00%> (-76.37%) ⬇️
...aidu/hugegraph/backend/store/hbase/HbaseStore.java 0.00% <0.00%> (-75.88%) ⬇️
...u/hugegraph/backend/store/hbase/HbaseSessions.java 0.00% <0.00%> (-60.60%) ⬇️
...ackend/store/cassandra/CassandraStoreProvider.java 42.85% <0.00%> (-57.15%) ⬇️
... and 73 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin

imbajin commented Nov 8, 2022

Copy link
Copy Markdown
Member

thanks for your contribution

wonder to know the differ with our current CI (like in toolchain @simon824 ) ,it use mvn mat:check to check the license.

and we don't need to add license header in github's file because they won't be packaged into source file. (refer pom.xml in root)

@dongzl

dongzl commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

toolchain

thanks for your contribution

wonder to know the differ with our current CI (like in toolchain @simon824 ) ,it use mvn mat:check to check the license.

and we don't need to add license header in github's file because they won't be packaged into source file. (refer pom.xml in root)

thanks for your contribution

wonder to know the differ with our current CI (like in toolchain @simon824 ) ,it use mvn mat:check to check the license.

and we don't need to add license header in github's file because they won't be packaged into source file. (refer pom.xml in root)

Thanks for your reply.

I am sorry, I don't understand the toolchain and how to use it. Do you mean apache-rat-plugin?

This PR License checker can check the file license automatically when someone submit new PR.

yes, we can ignore github package.

@imbajin

imbajin commented Nov 8, 2022

Copy link
Copy Markdown
Member

like this pr in toolchain(repo)

apache/hugegraph-toolchain#352

it also check the license in CI

@dongzl

dongzl commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

OK, I known, thanks.

License checker(use apache/skywalking-eyes) maybe more powerful.
It can check license, and add file license and replace file license in batches.

But the common scenes is check file license. we have these capability, I will close these this PR, thanks.

Do we have some communication tool, like wechat group?

@imbajin

imbajin commented Nov 8, 2022

Copy link
Copy Markdown
Member

seems it's nice if it could add the license automatically

@JackyYangPassion could u try or compare it?

and we do have the wechat group, I have send u a email including the ID already~

@simon824

simon824 commented Nov 8, 2022

Copy link
Copy Markdown
Member

add file license and replace file license in batches

hi @dongzl , add file license in batches does it means can automatic generate thrid-party dependancy LICENSE file ? (like these license files )

@dongzl

dongzl commented Nov 9, 2022

Copy link
Copy Markdown
Contributor Author

add file license and replace file license in batches

hi @dongzl , add file license in batches does it means can automatic generate thrid-party dependancy LICENSE file ? (like these license files )

Hi @simon824, It can add license header in batches when the source files doesn't have license header.

@dongzl

dongzl commented Nov 9, 2022

Copy link
Copy Markdown
Contributor Author

seems it's nice if it could add the license automatically

@JackyYangPassion could u try or compare it?

and we do have the wechat group, I have send u a email including the ID already~

Thanks, email is 598363102@qq.com or mobile(wechat ID) is 13436670847.

@imbajin

imbajin commented Nov 9, 2022

Copy link
Copy Markdown
Member

in current case, how dose it add the lin'celicense automatically?

image

@imbajin imbajin mentioned this pull request Nov 20, 2022
15 tasks
@imbajin imbajin changed the title add License checker for CI. chore(apache): add apache license checker for CI Nov 22, 2022
@imbajin

imbajin commented Nov 22, 2022

Copy link
Copy Markdown
Member

@dongzl

dongzl commented Nov 26, 2022

Copy link
Copy Markdown
Contributor Author

close by #2034

@dongzl dongzl closed this Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants