Skip to content

project_table is deprecated, remove references #1119

Closed

Description

@kevinjqliu

Feature Request / Improvement

project_table is still used in the codebase, leading to deprecation warning

@deprecated(
deprecated_in="0.8.0",
removed_in="0.9.0",
help_message="project_table is deprecated. Use ArrowScan.to_table instead.",
)
def project_table(

Remove all references
https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20project_table&type=code

and use ArrowScan.to_table instead

Activity

  1. souravsingh commented on Sep 1, 2024

    @souravsingh

    Hello, I am interested in working on this.

  2. kevinjqliu commented on Sep 1, 2024

    @kevinjqliu
    ContributorAuthor

    sounds good, assigned to you

  3. JE-Chen commented on Sep 16, 2024

    @JE-Chen
    Contributor

    I can’t replace all project_table using ArrowScan.to_table because ArrowScan.to_table is not a @staticmethod (need ArrowScan instance).

  4. kevinjqliu commented on Sep 16, 2024

    @kevinjqliu
    ContributorAuthor

    @JE-Chen
    You can create an ArrowScan instance like so

    def to_arrow(self) -> pa.Table:
    from pyiceberg.io.pyarrow import ArrowScan
    return ArrowScan(
    self.table_metadata, self.io, self.projection(), self.row_filter, self.case_sensitive, self.limit
    ).to_table(self.plan_files())

    The args should be the same as project_table

  5. kevinjqliu commented on Sep 20, 2024

    @kevinjqliu
    ContributorAuthor

    Closed by #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions