Repository navigation
fix pyiceberg-core's release process #1661
Description
What's the feature are you trying to implement?
While digging into the issue with the lack of LICENSE file in pyiceberg-core (#1653), i noticed a couple of other things missing from the pyiceberg-core release process.
Documenting them here:
- Add LICENSE and NOTICE files to
pyiceberg-corewheel and source distribution (Add LICENSE and NOTICE files for pyiceberg-core source distribution and wheel #1653) - Publish
pyiceberg-corewheel and sdist artifacts to https://downloads.apache.org/iceberg/ -
Add RAT check script, similar to pyiceberg's ./dev/check-license script and .rat-excludesthe repo already useapache/skywalking-eyesin the release script and in CI - Include
pyiceberg-corein "how to verify a release" docs (docs: add pyiceberg-core to "how to verify a release" #1660) - Double check LICENSE and NOTICE for
iceberg-rustartifacts (Add LICENSE and NOTICE files for pyiceberg-core source distribution and wheel #1653 (comment))
Willingness to contribute
None
Activity
[-]fix pyiceberg-core release process[/-][+]fix `pyiceberg-core`'s release process[/+]kevinjqliu commentedon Sep 7, 2025
According to the ASF release policy, every release must include the source packages. The current rust release artifact,
apache-iceberg-rust-0.6.0, already includes the source package forpyiceberg-core.Verified locally,
We can optionally choose to include wheels and python sdist in the release, similar to pyiceberg
kevinjqliu commentedon Sep 8, 2025
Instead of RAT, we can use
apache/skywalking-eyeshttps://grep.app/search?f.repo=apache%2Ficeberg-rust&f.repo.pattern=apache%2Fice&q=apache%2Fskywalking-eyes
Fokko commentedon Sep 8, 2025
Hey @kevinjqliu, first of all, thanks for fixing the loose ends here.
As you mentioned. The current source release already contains the
bindings/folder, en from an ASF perspective that's all that's required. The wheels are more as a convenience artifact. I would leave them out and publish the convenience artifacts directly to pypikevinjqliu commentedon Sep 8, 2025
sounds good, I agree! We can look to add this if someone finds it convenient to get the pyiceberg-core artifacts straight from https://downloads.apache.org/iceberg/ :)
Otherwise, the artifacts are in https://pypi.org/project/pyiceberg-core/#files or as fokko mentioned can be built using the
bindings/python/folder