Repository navigation
chore: exclude repo-only files from the source archive - #3189
Merged
Merged
Conversation
The release tarball is built with git archive and ships .asf.yaml, .devcontainer, .github, .gitignore, .gitattributes, and .idea, none of which are needed to build, test, or verify from source. Ryan raised this in the 0.2.0 vote and Kurtis called out .idea in the 0.9.1 vote. Files the verification scripts rely on (.licenserc.yaml, lint configs, dev/) stay in. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
kevinjqliu
force-pushed
the
chore/release-hygiene-cleanups
branch
from
September 10, 2026 07:10
809530e to
5289bba
Compare
kevinjqliu
changed the title
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Excludes IDE and repository metadata files from git archive-based release/source tarballs to keep distributed source archives focused on build/test essentials.
Changes:
- Adds
export-ignorerules for.idea/and several repo metadata/config paths in.gitattributes - Documents the intent and constraints for what must remain in the source archive
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1 +1,2 @@ | |||
| website export-ignore | |||
blackmwk
approved these changes
Sep 10, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kevinjqliu for this pr!
3 tasks
kevinjqliu
pushed a commit
that referenced
this pull request
Sep 10, 2026
* fix(ci): keep .github/actions in the source archive `.github export-ignore` (#3189) hides `.github/actions` from repository archives. GitHub resolves the `uses: $/...` self-repository references introduced in #3161 by fetching such an archive, so every workflow that uses a local composite action now fails at action resolution: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' for action 'apache/iceberg-rust/.github/actions/setup-builder@<sha>' This breaks CI on main and on all open pull requests. List the .github entries individually instead, so the repo-only files #3189 targeted stay out of the release tarball while `.github/actions` remains resolvable. A `-export-ignore` negation on the subdirectory does not work: git does not descend into an export-ignored directory. * comment
kevinjqliu
added a commit
that referenced
this pull request
Sep 10, 2026
* chore: exclude repo-only files from the source archive (#3189) The release tarball is built with git archive and ships .asf.yaml, .devcontainer, .github, .gitignore, .gitattributes, and .idea, none of which are needed to build, test, or verify from source. Ryan raised this in the 0.2.0 vote and Kurtis called out .idea in the 0.9.1 vote. Files the verification scripts rely on (.licenserc.yaml, lint configs, dev/) stay in. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit d6c2eb4) * fix(ci): keep .github/actions in the source archive (#3193) `.github export-ignore` (#3189) hides `.github/actions` from repository archives. GitHub resolves the `uses: ./...` self-repository references by fetching such an archive, so every workflow that uses a local composite action fails at action resolution: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' for action 'apache/iceberg-rust/.github/actions/setup-builder@<sha>' List the .github entries individually instead, so the repo-only files #3189 targeted stay out of the release tarball while `.github/actions` remains resolvable. A `-export-ignore` negation on the subdirectory does not work: git does not descend into an export-ignored directory. (cherry picked from commit 6f062aa) --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Xander <zander181@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Trim the source tarball. We build it with
git archive, which includes everything in the repo. This addsexport-ignorefor the repo-only files:.asf.yaml,.devcontainer,.github,.gitignore,.gitattributes, and.idea.This came up twice in RC votes.
.gitignore,.github,.asf.yamletc. in the 0.2.0 vote: https://lists.apache.org/thread/1rnk9c1ldjhd160bfxvdyk7mlkzrjj03..idea/vcs.xmlin the 0.9.1 RC3 vote: https://lists.apache.org/thread/24bsb6hllp6kvk3ow7b4gsncp5cjf79oEverything the verify script needs stays in:
.licenserc.yamlfor the header check, the lint configs formake check,dev/for tests and release scripts.Are these changes tested?
Extracted the archive and ran the header check,
make check-toml, anddev/check_license_notice.shfrom it. All pass. None of the excluded paths show up ingit archive HEAD | tar -t.AI Disclosure
Drafted with Claude Code, reviewed by me.
🤖 Generated with Claude Code