Repository navigation
build: disable unused zstd legacy feature - #3495
Merged
blackmwk merged 3 commits intoOct 21, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Brotli is still a supported Parquet codec for reads and writes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
changed the title
kevinjqliu
marked this pull request as ready for review
October 20, 2026 20:43
This was referenced Oct 20, 2026
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open issue
What changed in this PR
Disables zstd’s default features to avoid compiling the legacy decoder code path, simplifying wheel license attributions and aligning with upstream dependency configurations.
Changes:
- Switch
zstddependency todefault-features = falsein the workspaceCargo.toml.
| File | Description |
|---|---|
| Cargo.toml | Disables zstd default features (including legacy frame support) to reduce compiled code and license attribution needs. |
Review effort: Lite
Copilot stopped reviewing on behalf of
kevinjqliu due to an error
October 20, 2026 23:25
3 tasks
dannycjones
approved these changes
Oct 21, 2026
dannycjones
left a comment
dannycjones
left a comment
Contributor
There was a problem hiding this comment.
Great find on this, that removes the dependency on BSD-2-Claude inside C files too.
blackmwk
approved these changes
Oct 21, 2026
dannycjones
added a commit
to dannycjones/iceberg-rust
that referenced
this pull request
Oct 26, 2026
Backport of apache#3495 to 0.11.x. Dropping zstd's default features turns off zstd-sys/legacy, so the vendored legacy decoders under zstd/lib/legacy are no longer compiled into the pyiceberg-core wheels. Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> Co-authored-by: Danny C Jones <djonesoa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
zstd's
legacyfeature (decoders for pre-1.0 zstd frames) is on by default but nothing here needs it, since Parquet, Puffin and Avro all use standard zstd frames. Turning it off means that code isn't compiled in, so thepyiceberg-corewheel LICENSE doesn't need the BSD-2 attribution for it.Same setting upstream: arrow-rs
parquet, arrow-rsarrow-ipc, DataFusion workspace and avro-rs all usezstdwithdefault-features = false.Are these changes tested?
Dependency-only change, covered by existing tests:
cargo check --all-targets: passedcargo test -p iceberg --lib: passed (1991 passed, 0 failed)AI Disclosure
Drafted with Copilot. Worth a look: that no other crate relies on zstd's
legacyfeature.