Repository navigation
refactor(scan): rename position delete index key to referenced data file - #3570
Open
dragonknightk wants to merge 1 commit into
Open
dragonknightk wants to merge 1 commit into
dragonknightk wants to merge 1 commit into
Conversation
`PopulatedDeleteFileIndex::pos_deletes_by_path` is keyed by the path of the data file a position delete refers to, not by the delete file's own path. The name left that ambiguous, so rename the field and its local bindings to `pos_deletes_by_referenced_data_file` and update the comments that mention it. Closes apache#3359, the follow-up requested in the apache#3145 review. The field is private, so there is no behavior or public API change. Generated-by: Codex and Grok Bot, working for dragonknightk
Author
|
Hi @mbutrovich — this closes #3359, the rename you asked to track in the #3145 review. One file, 14 lines, private field only: no behavior or public API change. |
mbutrovich
approved these changes
Oct 28, 2026
mbutrovich
left a comment
mbutrovich
left a comment
Collaborator
There was a problem hiding this comment.
Straightforward mechanical rename, thanks @dragonknightk!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Renames
PopulatedDeleteFileIndex::pos_deletes_by_pathtopos_deletes_by_referenced_data_fileincrates/iceberg/src/delete_file_index.rs, together with its local bindingsand the comments that mention it.
The field is keyed by the path of the data file a position delete applies to,
not by the delete file's own path, so the old name was ambiguous. It is
private, so there is no behavior or public API change.
Are these changes tested?
Existing coverage only; no test was added or changed.
cargo fmt --all -- --check,cargo clippy -p iceberg --all-targets -- -D warnings, andcargo test -p iceberg --lib delete_file_index(23 tests) all pass.AI Disclosure
Codex and Grok Bot, working for dragonknightk, contributed to this code.