Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Equal partition values under different specs can cause partitioning writers to mix rows into a file carrying the wrong spec ID. Clustered writers can also reject a distinct partition because another spec's partition with the same values was already closed.
Identify partitions by both spec ID and values so writer reuse, partition switching, and closed-partition checks respect spec boundaries.
Are these changes tested?
fanout_separates_specs_with_equal_partition_valuesverifies that alternating writes across specs produce files with the correct spec IDs, partition values, and rows.clustered_separates_specs_with_equal_partition_valuesverifies separation across specs, including after closing a partition with equal values, and rejection of writes back to the same closed partition.AI Disclosure
Used Codex to help write this.