Parquet: Make createStructReader with fieldId abstract - #17698
Merged
huaxingao merged 1 commit intoAug 23, 2026
Conversation
Contributor
Author
|
@RussellSpitzer can you help take a look? I also make 3 argument of |
uros-b
approved these changes
Aug 18, 2026
Member
|
Thank you @dramaticlly! |
createStructReader(List, StructType) was deprecated for removal in 1.12.0 in favor of createStructReader(List, StructType, Integer). The 2-arg form threw UnsupportedOperationException and the 3-arg form defaulted to delegating to it, so neither was usable without an override. Remove the 2-arg method and make the 3-arg form abstract. Both subclasses (GenericParquetReaders, InternalReader) already override it, and BaseParquetReaders is package-private so no other subclass can exist.
dramaticlly
force-pushed
the
1.12deprecation-parquet-struct-reader
branch
from
August 18, 2026 21:11
79f94fd to
e0efb98
Compare
Contributor
Author
|
@huaxingao can you help check this as well? |
Contributor
|
Thanks @dramaticlly for the PR! Thanks @uros-b for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createStructReader(List, StructType) was deprecated for removal in 1.12.0 in favor of createStructReader(List, StructType, Integer). The 2-arg form threw UnsupportedOperationException and the 3-arg form defaulted to delegating to it, so neither was usable without an override.
Remove the 2-arg method and make the 3-arg form abstract. Both subclasses (GenericParquetReaders, InternalReader) already override it, and BaseParquetReaders is package-private so no other subclass can exist.
AI Disclosure
Model: Claude Opus 5 (1M context)
Platform/Tool: Claude Code
Human Oversight: reviewed
Prompt Summary: split #16449 into smaller self-contained PRs; verify each group compiles and tests green standalone