clone partial columns of aligned tvlist for query - #18409
Draft
shuwenwei wants to merge 7 commits into
Draft
Conversation
shuwenwei
changed the title
…ager test fakes The cherry-pick added the releaseMemoryImmediately(long) method to the calc-commons MemoryReservationManager interface, but four test classes that implement the interface directly were not updated, breaking test compilation. Add the missing method to each fake, mirroring the semantics of the existing releaseMemoryCumulatively implementation in each class.
- ResourceByPathUtilsTest: getResourceInstance(IFullPath) requires a NonAlignedFullPath; MeasurementPath does not implement IFullPath, so the test no longer compiled. Build the NonAlignedFullPath from IDeviceID.Factory.DEFAULT_FACTORY and a MeasurementSchema. - FragmentInstanceExecutionTest: use IDeviceID.Factory.DEFAULT_FACTORY.create directly instead of DeviceIDFactory.getInstance().getDeviceID(new PartialPath(...)), matching the query-side NonAlignedFullPath construction in the same file, and drop the now-unused imports.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #18394 ([To dev/1.3] clone partial columns of aligned tvlist for query).
Commit:
edeb7c5276For queries that touch only a few columns of a wide aligned device, clone only the accessed columns of the working
AlignedTVListinstead of the whole list, then swap the working list so the unaccessed columns are moved out. This dramatically reduces the memory retained by such queries on wide aligned devices.This cherry-pick also carries over the follow-up fixes from the dev/1.3 PR:
prepareTvListMapForQueryretries under thememChunklock after acquiring the candidate'squeryListLock, so a swapped working list can never be operated on while holding a stale lock.memChunkcritical section.RamInfoaccounting keeps reservation and cleanup sizes consistent.Adapted to the current master APIs (IFullPath/AlignedFullPath, ModEntry, table-model chunk metadata, i18n messages) during conflict resolution.