Skip to content

Pipe: Reject plugin jars that conflict with parent ClassLoader bytecode - #18410

Open
luoluoyuyu wants to merge 2 commits into
apache:masterfrom
luoluoyuyu:fix/pipe-plugin-classloader-bytecode-conflict
Open

Pipe: Reject plugin jars that conflict with parent ClassLoader bytecode#18410
luoluoyuyu wants to merge 2 commits into
apache:masterfrom
luoluoyuyu:fix/pipe-plugin-classloader-bytecode-conflict

Conversation

@luoluoyuyu

Copy link
Copy Markdown
Member

Description

Restore standard parent-delegation for PipePluginClassLoader and fail fast when a plugin ships the same class name with different bytecode, without defining classes into the parent during the check.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Restore standard parent-delegation for PipePluginClassLoader and fail
fast when a plugin ships the same class name with different bytecode,
without defining classes into the parent during the check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant