Repository navigation
Webadmin api pem - #3224
Webadmin api pem#3224prosgarz35 wants to merge 12 commits into
Conversation
i am testing why build fails but yeah one cert for all for surely better than pain in ass for anyone who making certs (especialy when in 2027-28 they become 47-48 days ye?) |
|
I dont know why it faild to build, help me please dear @chibenwa |
|
I just trigger a new build FYI. |
Thanks alot, why it is happening? I see errors and its nothing to my code don't it? |
|
|
What is the upside of adding this complexity to James? |
Having direct .pem support for the Webadmin API actually decreases the operational complexity for system administrators, rather than increasing it. |
I do see the point that using different formats in one code base doesn't make sense.
The shift to short-lived certificates encourages automation. Unless you also want to build ACME into James, you need additional software running next to James anyway. Why not let that software also handle the TLS termination so that we do not have to worry about that stuff at all?
This should not be the goal.
Usually less than 10 lines of configuration. |
If you ask me i am personaly also dont see point have oldschool java keystores but that not me who choose remove it or not. About acme into james well i think its good because james complete mail server suit? Then without certificates its not completed because some external mail server just dont even receive you mail in terms of anti bot defense. Acme library i see in some projects but this i think too much for one PR. |
|
James uses PEM or keystore for IMAP/SSL set up
|
For me, a software can be complete without doing everything on its own. James also uses software specialized on data storage, so why not also use software specialized on certificate management and TLS?
I'd say that ACME support for James is generally too much, not only for one PR but in general. |
| Preconditions.checkState(hasKeystoreInformation() || hasPemInformation(), | ||
| "If enabled, you need to provide keystore information or (certificates and privateKey)"); |
There was a problem hiding this comment.
We need to do a better job here:
- Reject specifying both keystore and pem as otherwize the behaviour is ambiguous
- Reject half configured PEM. An explicit error on what is missing is way better then a silent http downgrade.
|
Hello @prosgarz35 |
As said on the mailing list, I am not necessarily in favor of handling TLS here because you have to run an ACME client externally anyway. However, I'm fine with this if we drop the keystore support in the future and continue with only X509. @prosgarz35 I do not really like the wording |
I'm presume I'm the one to blame for this. I propose we add exact mentions in the doc, but I would be a bit more reluctant to have config changes (retro-compatibility...) |
follow up for full .pem cert mechanics
#3223