Skip to content

Minor Bugs Fixes #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prosgarz35 wants to merge 3 commits into from
Closed

Minor Bugs Fixes #3246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07b66ba
Enable TCP_NODELAY on protocol server child channels to reduce latency
prosgarz35 Oct 9, 2026
7c1d3f8
fix(protocols): unregister existing mbean before registering on serve…
prosgarz35 Oct 9, 2026
1c7730a
fix(jmx): eliminate race condition during concurrent Netty server res…
prosgarz35 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...y/src/main/java/org/apache/james/protocols/lib/netty/AbstractConfigurableAsyncServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,22 @@ public final void setEncryptionFactory(Encryption.Factory encryptionFactory) {
}

protected void registerMBean() {

try {
mbeanServer.registerMBean(this, new ObjectName(getMBeanName()));
ObjectName objectName = new ObjectName(getMBeanName());
synchronized (mbeanServer) {
if (mbeanServer.isRegistered(objectName)) {
mbeanServer.unregisterMBean(objectName);
}
try {
mbeanServer.registerMBean(this, objectName);
} catch (javax.management.InstanceAlreadyExistsException e) {
mbeanServer.unregisterMBean(objectName);
mbeanServer.registerMBean(this, objectName);
}
}
} catch (Exception e) {
throw new RuntimeException("Unable to register mbean", e);
}

}

protected void unregisterMBean() {
Expand Down Expand Up @@ -481,8 +490,9 @@ public String[] getBoundAddresses() {
protected void configureBootstrap(ServerBootstrap bootstrap) {
super.configureBootstrap(bootstrap);

// enable tcp keep-alives
// enable tcp keep-alives and disable Nagle's algorithm for low latency
bootstrap.childOption(ChannelOption.SO_KEEPALIVE, true);
bootstrap.childOption(ChannelOption.TCP_NODELAY, true);
Comment on lines -484 to +486

@chibenwa chibenwa Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does nothing new.

super.configureBootstrap(bootstrap) already sets it in protocols/netty/src/main/java/org/apache/james/protocols/netty/AbstractAsyncServer.java:182

The added line sets it a second time, and the new comment wrongly suggests it wasn't set before.

}

protected abstract ChannelHandlerFactory createFrameHandlerFactory();
Expand Down