KAFKA-20932: Track replaced remote log segments as unreferenced - #23148
Open
Gimini-3 wants to merge 1 commit into
Open
KAFKA-20932: Track replaced remote log segments as unreferenced#23148Gimini-3 wants to merge 1 commit into
Gimini-3 wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex (GPT-5)
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteLogLeaderEpochStatecould drop an existing segment from both the referenced offset map and the unreferenced set when a later overlapping segment reused its start offset while a higher tail segment remained.The global
highestLogOffsetcheck prevents the overlap-removal loop from running in this case, and the previous value returned byoffsetToId.putwas ignored. This left the replaced segment in the partition metadata map but absent from leader-epoch listings used by remote retention cleanup.This change records a distinct replaced segment as unreferenced and adds a regression test covering:
S0 = [0, 100]S1 = [101, 200]S2 = [0, 150]S2completion updateJira: https://issues.apache.org/jira/browse/KAFKA-20932
Testing:
./gradlew :storage:test --tests org.apache.kafka.server.log.remote.metadata.storage.RemoteLogLeaderEpochStateTest./gradlew :storage:spotlessCheckThe contribution is my original work and I license it to the project under the project's open source license.