Skip to content

ci: retry a workspace check once when it crashes - #1644

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:ci/retry-crashed-workspace-check
Oct 16, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:ci/retry-crashed-workspace-check

Conversation

@potiuk

@potiuk potiuk commented Oct 15, 2026

Copy link
Copy Markdown
Member

Summary

Type of change

  • CI / dev loop (prek, workflows, validators)

Test plan

  • prek run --all-files passes
  • Exercised with a fake uv on PATH in a scratch workspace:
    • crashes once (SIGSEGV), then passes → exit 0, 2 calls;
    • crashes twice → exit 1, 2 calls;
    • real lint failure (exit 1) → exit 1, 1 call, no retry.

Linked issues

None.


Generative AI disclosure: drafted with Claude Code (Opus 5.5) and reviewed by the author.

🤖 Generated with Claude Code

ruff 0.16.9 has segfaulted on CI runners while checking members whose
code the PR did not touch (vetted-ops on apache#1636, maildir on apache#1642),
failing prek for reasons unrelated to the change.

run-workspace-check.sh now treats an exit status above 128, a process
killed by a signal, as a crash rather than a finding, and runs that
member once more. A real finding (exit 1) is never retried, and a
second crash still fails the check.

Generated-by: Claude Code (Opus 5.5)
@potiuk potiuk added family:ci .github workflows, prek, validators substrate:framework-dev Tool substrate: build / validate / eval the framework itself labels Oct 15, 2026
@github-actions github-actions Bot added the family:tools tools/* label Oct 15, 2026
@potiuk
potiuk merged commit 5826a91 into apache:main Oct 16, 2026
55 checks passed
potiuk added a commit to Kaap10/magpie that referenced this pull request Oct 16, 2026
ruff 0.16.9 has segfaulted on CI runners while checking members whose
code the PR did not touch (vetted-ops on apache#1636, maildir on apache#1642),
failing prek for reasons unrelated to the change.

run-workspace-check.sh now treats an exit status above 128, a process
killed by a signal, as a crash rather than a finding, and runs that
member once more. A real finding (exit 1) is never retried, and a
second crash still fails the check.

Generated-by: Claude Code (Opus 5.5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

family:ci .github workflows, prek, validators family:tools tools/* substrate:framework-dev Tool substrate: build / validate / eval the framework itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant