You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build(desktop): goal services adapter test uses removed SessionChangedEvent field #3641
Running the Desktop build from the current main branch fails during build:main. The new Goal services adapter test constructs three SessionChangedEvent fixtures with a type: 'sessions_changed' property, but that property is no longer part of the shared interface.
Expected behavior: npm run build succeeds and test fixtures conform to the current SessionChangedEvent contract.
How to reproduce
Check out commit e6e0c34c7 or the current main branch.
Install dependencies from the repository root.
Run:
npm --workspace @maka/desktop run build:main
TypeScript reports TS2353 at lines 64, 70, and 76 of apps/desktop/src/main/__tests__/goal-services-adapter.test.ts.
Environment
Maka commit: e6e0c34c7
OS: macOS 15.7.3, Apple Silicon
Surface: Desktop
Node.js: 24.14.0
npm: 11.19.0
Logs, screenshots, or additional context
src/main/__tests__/goal-services-adapter.test.ts(64,7): error TS2353:
Object literal may only specify known properties, and 'type' does not exist in type 'SessionChangedEvent'.
src/main/__tests__/goal-services-adapter.test.ts(70,7): error TS2353:
Object literal may only specify known properties, and 'type' does not exist in type 'SessionChangedEvent'.
src/main/__tests__/goal-services-adapter.test.ts(76,7): error TS2353:
Object literal may only specify known properties, and 'type' does not exist in type 'SessionChangedEvent'.
PR #3613 removed the unused event discriminator from SessionChangedEvent. PR #3531 subsequently introduced the adapter test from a stale event shape. Open PR #3639 independently records this current-main failure as a blocker to full Desktop typechecking.
The minimal fix is to remove the three stale type properties from the test fixtures.
Activity
fix(desktop): align goal adapter event fixtures
fix(desktop): align goal adapter event fixtures
liuxiaocs7 commentedon Aug 23, 2026
solved by #3642