You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(desktop): route Rive diagnostics through the core secret redactor #4925
apps/desktop/src/main/rive-cli.ts maintains a private redactRiveText implementation alongside the authoritative @maka/core/redaction rules. The local copy only recognizes a small set of bearer, sk-, and key/value patterns, so newly supported credentials such as GitHub, Google, or Slack tokens can be emitted in Rive diagnostics and tool output.
Scope
Make the core redactor the single source of truth for Rive stdout/stderr tails, error envelopes, command display, and structured values.
Keep the existing deep-value traversal and maximum-depth guard, and preserve the current Rive helper exports where callers use them.
Keep the command protocol and result shape unchanged.
Acceptance criteria
Rive output and error projections never expose core-supported token forms or sensitive keyed values.
Nested arrays/objects remain bounded by the existing depth policy.
Existing Rive workflow tests pass, with regression coverage for at least one token form that the local implementation missed.
This issue has had no human activity for 30 days and has been marked stale. It will be closed in 30 days unless someone comments.
If the issue is still current, please confirm it against the latest main and add any information that would help move it forward. Assigned issues and issues labelled pinned are exempt from this policy.
Activity
seekskyworld commentedon Sep 6, 2026
我认领这个切片。将把 Rive 的文本与结构化值脱敏统一到 @maka/core/redaction,保留深度上限、结果协议和现有调用方,并补充核心 token 形态回归测试。实现从最新 upstream/main 独立分支开始。
Adarsh-Me commentedon Sep 6, 2026
Take
github-actions commentedon Oct 7, 2026
This issue has had no human activity for 30 days and has been marked stale. It will be closed in 30 days unless someone comments.
If the issue is still current, please confirm it against the latest
mainand add any information that would help move it forward. Assigned issues and issues labelledpinnedare exempt from this policy.