Repository navigation
refactor(desktop): centralize preload bridge contract - #1204
Merged
Astro-Han merged 3 commits intoJul 18, 2026
Merged
Conversation
10 of 23 tasks
Astro-Han
reviewed
Jul 18, 2026
Astro-Han
approved these changes
Jul 18, 2026
Contributor
|
LGTM now. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.makashape into a preload-ownedMakaBridgecontractglobal.d.tsas a small global augmentationsrc/mainand preserve the existing byte wire format and IPC channelsPermissionActionResultfailure union across the preload contract and runtime bridgeScope
This is behavior- and visually-neutral. It does not rename IPC channels, expand renderer capabilities, or change the exposed bridge surface. The contract is aligned with the existing runtime, including memory proposal methods and permission result shapes.
Part of #1084
Verification
npx tsc -p apps/desktop/tsconfig.preload.json --noEmitnpm --workspace @maka/desktop run build:preloadLocaleProviderAPI mismatchnpx biome linton all changed source/test filesgit diff --checkThe full Desktop typecheck remains blocked by pre-existing mainline issues: the current
LocaleProviderprop migration, stalemcpnavigation union values, and unavailable local@maka/mcpbuild declarations.