Repository navigation
refactor: reuse shared result and hashing helpers - #1374
Merged
Astro-Han merged 2 commits intoJul 24, 2026
Merged
Conversation
Astro-Han
approved these changes
Jul 23, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Result now has one implementation at @maka/core/result, while the old settings path re-exports the same function identities for compatibility. Semantic compact reuses the shared hashing code, and the small adapter preserves the existing raw-hex storage format. I also verified that the digest fixture matches the previous implementation. No findings.
This was referenced Jul 23, 2026
Contributor
|
A rebase is needed before merging. @me2seeks Would you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Result<T>helpers to@maka/core/result, keep@maka/core/settings/resultas a compatibility re-export, and migrate all current production consumersstableHashandstableStringifyfromrequest-shape.tsinsemantic-compact.tsThis is the core + runtime mechanical batch from #1084. It is behavior- and visually-neutral.
Refs #1084.
Verification
npm run lint— passednpm run format:check— passednpm run build— passednpm run typecheck— passednpm --workspace @maka/core test— 1,157 passed, 0 failednpm --workspace @maka/runtime test— 2,376 passed, 0 failed, 3 skippedgit diff origin/main...HEAD --check— passedVisual validation is not applicable because this is a behavior- and visually-neutral utility cleanup.
Review focus
stableHashincludes asha256:prefix, while the persisted semantic compact fields currently use raw hex; the smallstableHashHexadapter intentionally preserves that existing format