Repository navigation
refactor(cli): extract shell-run hydration controller - #1440
Merged
Merged
Conversation
Astro-Han
approved these changes
Jul 25, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
No findings. The controller now owns hydration state, buffering, retries, and subscription teardown. pi-tui-runner keeps only the transcript, ticker, and render wiring.
The runner tests cover the concurrency and lifecycle behavior affected by this extraction. Approving.
GitHub has not reported remote checks for this branch, so CI should still run before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi-tui-runner.tsresponsible only for driver, transcript, ticker, and render wiringVerification
npm --workspace maka-agent run typechecknode --test packages/cli/dist/__tests__/pi-tui-runner.test.js(197 tests passed)npx biome format packages/cli/src/pi-tui-runner.ts packages/cli/src/shell-run-hydration.tsnpx biome lint packages/cli/src/pi-tui-runner.ts packages/cli/src/shell-run-hydration.tsgit diff --checkI also ran
npm --workspace maka-agent test: 643 tests passed, while four existing runtime-bootstrap sandbox tests could not run because this host does not provide the required command sandbox. The complete suite is left to CI.Fixes #1412