Repository navigation
fix(ui): finish --ease-linear in animation catalog stories - #434
Merged
Merged
Conversation
Follow-up to #431: the merged PR tokenized shimmer but left the status pulse as bare `ease-in-out` and the Easing Scale story without the new `--ease-linear` entry. Finish the catalog so all developer-facing easing examples use `var(--ease-*)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #431: finish
--ease-linearcoverage in the Animation Catalog story so all developer-facing easing examples usevar(--ease-*).Why
#431 added the
--ease-lineartoken and banned bare timing keywords, but the merged PR left the Animation Catalog half-tokenized — shimmer usedvar(--ease-linear)while the status pulse still used bareease-in-out, and the Easing Scale story didn't list the new--ease-lineartoken.Scope
Changed:
animation-catalog.stories.tsx:24status pulse:ease-in-out→var(--ease-in-out-strong)--ease-linearentry (linear, infinite-loop functional animations)--ease-linearusageVerification
npm run -w @maka/desktop test: 1667/1667 passnpm run typecheck: cleanReviewer notes
packages/ui/stories/, outside the contract test's scan range (packages/ui/src+apps/desktop/src/renderer), so this is a developer-facing consistency fix, not a contract requirement.