Skip to content

fix(ui): let New project choose a folder without a custom name - #6059

Closed
Master-Frank wants to merge 1 commit into
apache:mainfrom
Master-Frank:cursor/optional-new-project-name-e179
Closed

Master-Frank wants to merge 1 commit into
apache:mainfrom
Master-Frank:cursor/optional-new-project-name-e179

Conversation

@Master-Frank

Copy link
Copy Markdown
Contributor

Summary

Creating a project in the desktop app required a custom name before Choose folder would enable. An empty name is a valid choice and means “name this project after the folder I pick.”

NewProjectDialog now submits with the name field empty. Choose folder stays available either way. A typed name is still trimmed and applied in the same projects.add step; a blank name is omitted so the existing folder-basename fallback in projects.add applies. The en / zh-CN / zh-TW copy no longer says the name has to come first.

Fixes #6047

Verification

  • npx biome check on the changed files
  • npm --workspace @maka/ui run build and node --test packages/ui/dist/__tests__/new-project-dialog.test.js (4 pass)
  • node --test packages/ui/dist/__tests__/conversation-copy.test.js (7 pass)
  • npm run check:locale-hygiene
  • Desktop renderer typecheck (tsc -p apps/desktop/tsconfig.renderer.json --noEmit)
  • node --test --test-force-exit apps/desktop/dist/main/__tests__/project-add-restore.test.js apps/desktop/dist/main/__tests__/task-entry-provider-scope.test.js apps/desktop/dist/main/__tests__/task-entry-controller.test.js (80 pass), including the new “Settings Add with a blank name still opens the folder picker” case

Not run: Electron desktop app / native folder picker. Those are not available in this environment; the behavior is covered by the dialog and Settings registration tests.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Creating a project required typing a name before Choose folder would
enable. An empty name is a valid choice: the catalog already names the
project after the folder when projects.add is called without one.

Leave the name field optional, keep Choose folder available, and pass a
trimmed name through only when one was typed. Update en / zh-CN / zh-TW
copy to match.

Fixes apache#6047

Generated-by: Cursor Grok 4.6
@github-actions github-actions Bot added the effort/M Under 500 readable lines label Oct 11, 2026
@Astro-Han

Copy link
Copy Markdown
Contributor

Thank you for this contribution, and sorry to close it on process grounds rather than on its merits.

The commit in this PR carries Generated-by: Cursor Grok 4.6. SpaceXAI recently changed Grok's Acceptable Use Policy to bar using Grok or its output to develop, or assist anyone in developing, products or services that compete with SpaceXAI, directly or indirectly. That is a field-of-use restriction, and under the ASF's draft generative tooling criteria it would likely place Grok in Category X. It is being discussed on legal-discuss now, and until that is settled the project has been asked not to accept Grok-generated contributions. Code merged here ships under the Apache License to everyone, so the restriction matters even though Maka itself is not the concern.

This is not a judgement on the change itself. If you would like to continue, please re-create it with a different tool (or by hand) and open a new PR, noting the tool in the disclosure as usual. We will review it normally.

Automated notice: This comment was posted by an automated agent operated by Astro-Han, at the maintainer's direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New project requires a name before the folder can be chosen

3 participants