Make only-mvnw.cmd pick the first matching extracted directory (#442) - #447
Open
tanvir-ux wants to merge 1 commit into
Open
Make only-mvnw.cmd pick the first matching extracted directory (#442)#447tanvir-ux wants to merge 1 commit into
tanvir-ux wants to merge 1 commit into
Conversation
Unix only-mvnw already stops at the first directory that contains bin/$MVN_CMD. The Windows script kept scanning and used the last match, so the two scripts could select different distributions from the same archive. Fixes apache#442
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the extracted archive directory name does not match the archive filename, both wrapper scripts scan for a subdirectory that contains
bin/$MVN_CMD. Unixonly-mvnwalready stops at the first match.only-mvnw.cmdusedForEach-Objectwith no early exit, so the last match won.I changed the Windows scan to a
foreachwithbreakso both scripts pick the same directory from the same archive.Fixes #442
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).This is a few-line script change in
only-mvnw.cmd. I did not add a PowerShell test harness.