HDDS-16015. Make listStatusLight skip SCM pipeline refresh. - #10894
Open
aryangupta1998 wants to merge 4 commits into
Open
HDDS-16015. Make listStatusLight skip SCM pipeline refresh.#10894aryangupta1998 wants to merge 4 commits into
aryangupta1998 wants to merge 4 commits into
Conversation
sadanand48
reviewed
Aug 6, 2026
sadanand48
approved these changes
Aug 6, 2026
sadanand48
left a comment
sadanand48
left a comment
Contributor
There was a problem hiding this comment.
Thanks @aryangupta1998 for the patch, LGTM
yandrey321
reviewed
Aug 6, 2026
| // Please refer this jira for more details. | ||
| refreshPipelineFromCache(keyInfoList); | ||
| if (refreshPipelineInfo) { | ||
| // refreshPipeline flag check has been removed as part of |
Contributor
There was a problem hiding this comment.
it seems like the same flag check was removed some time ago. So comments should be adjusted after checking that the same issue would not be reintroduced after this fix.
yandrey321
reviewed
Aug 6, 2026
| checkAcls(getResourceType(resolvedArgs), StoreType.OZONE, ACLType.READ, | ||
| bucket, resolvedArgs.getKeyName()); | ||
| } | ||
| metrics.incNumListStatus(); |
Contributor
There was a problem hiding this comment.
should be the last call in the try block
yandrey321
reviewed
Aug 6, 2026
| auditMap, ex)); | ||
| throw ex; | ||
| } finally { | ||
| if (auditSuccess) { |
Contributor
There was a problem hiding this comment.
should be inside try block, otherwise would audit failure as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
-> Updated the OM light listing path so listStatusLight() no longer triggers SCM-backed pipeline refresh.
-> Added a refreshPipelineInfo switch in KeyManagerImpl.listStatus(...) so normal listings keep existing behavior while light listings stay metadata-only.
-> Wired OmMetadataReader and OmSnapshot to use the light path consistently, and added a unit test to verify no pipeline refresh call is made.
Why
-> ozone fs -du and other light listing flows only need metadata and size information.
-> Skipping pipeline refresh reduces unnecessary SCM traffic and lowers latency for light read paths.
-> Normal listStatus() behavior remains unchanged.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16015
How was this patch tested?
-> Added a unit test in TestKeyManagerUnit that calls listStatusLight() and verifies SCM container pipeline lookup is not invoked.
-> Existing listStatus() behavior remains covered by the current unit test.