HDDS-16036. SCM Support allocate Container by StoragePolicy - #10946
HDDS-16036. SCM Support allocate Container by StoragePolicy#10946xichen01 wants to merge 5 commits into
Conversation
|
@xichen01 is this PR still in progress ? |
I'm just fixing up the test, it's ready for review. |
|
@amaliujia @greenwich @chungen0126 @ivandika3 @peterxcli @devmadhuu Please help to review |
|
Added HDDS-16116 for rebasing HDDS-11233 feature branch with master. Keep hold till rebase finished. |
c6cc43d to
8decb32
Compare
chungen0126
left a comment
chungen0126
left a comment
There was a problem hiding this comment.
Thanks @xichen01 for working on this.
| public static final String OZONE_DEFAULT_STORAGE_TIER_KEY = | ||
| "ozone.default.storageTier"; |
There was a problem hiding this comment.
It would be better to change this to ozone.server.default.storage.tier.
| public static final String OZONE_DEFAULT_STORAGE_TIER_DEFAULT = | ||
| StorageTier.DISK.toString(); | ||
|
|
||
| public static final String OZONE_DEFAULT_STORAGE_POLICY_KEY = "ozone.default.storagepolicy"; |
There was a problem hiding this comment.
It would be better to change this to ozone.server.default.storage.policy.
| </property> | ||
|
|
||
| <property> | ||
| <name>ozone.default.storagepolicy</name> |
There was a problem hiding this comment.
It would be better to change this to ozone.server.default.storage.policy.
| @Deprecated | ||
| default List<AllocatedBlock> allocateBlock(long size, int numBlocks, | ||
| ReplicationType type, ReplicationFactor factor, String owner, | ||
| ExcludeList excludeList) throws IOException, TimeoutException { | ||
| return allocateBlock(size, numBlocks, ReplicationConfig | ||
| .fromProtoTypeAndFactor(type, factor), owner, excludeList); | ||
| } | ||
|
|
There was a problem hiding this comment.
Since ScmBlockLocationProtocol is a public RPC protocol interface, removing this method changes the interface signatures and may break binary/backward compatibility for older clients or dependencies that haven't been recompiled against the new version (causing NoSuchMethodError at runtime).
Is there a reason to remove this deprecated default method in this PR, or should we retain it for backward compatibility?
|
@xichen01 I updated the shared feature branch HDDS-11233 on apache/ozone master to bring it up to date with master. The branch now = the original feature commits (unchanged SHAs) with a single Merge 'upstream/master' commit on top. New tip: 8decb32. Kindly do merge of this feature branch to your PR branch and resolve the conflicts. |
Apologies for this confusion. Yes I rebased and force pushed the HDDS-11233 , but we need to follow the merge process instead of rebase for feature branches and raise PRs and follow the normal PR process. So I reverted the earlier forced push and now raised this PR #10983 |
3 participants
What changes were proposed in this pull request?
StoragePolicyin the SCM sideStoragePolicyandallowFallbackStoragePolicyStoragePolicyandallowFallbackStoragePolicy.For the old client the
StoragePolicywill be null, the SCM will useOzoneStoragePolicy.getDefaultPolicy()as the defaultStoragePolicyfor the old client,The default policy can be configured by Configuration
ozone.default.storagepolicythe default value is WARMFYI:
Releated doc and discuss: #6989
A preview version for the full "Ozone Storage Policy" feature: https://github.com/ivandika3/ozone/tree/refs/heads/backport-storage-policy-storage-class
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16036
How was this patch tested?
New added tests