Skip to content

HDDS-16090. Parameterize TestOzoneShellHA with follower read - #10954

Merged
adoroszlai merged 2 commits into
apache:masterfrom
adoroszlai:HDDS-16090
Aug 6, 2026
Merged

HDDS-16090. Parameterize TestOzoneShellHA with follower read#10954
adoroszlai merged 2 commits into
apache:masterfrom
adoroszlai:HDDS-16090

Conversation

@adoroszlai

@adoroszlai adoroszlai commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Refactor TestOzoneShellHAWithFollowerRead to avoid subclassing TestOzoneShellHA:

  • make TestOzoneShellHA parameterized, run all test cases with follower read enabled/disabled
  • TestOzoneShellHAWithFollowerRead only runs the two additional test cases

Remove TestOzoneShellHAWithFSO, since TestOzoneShellHA also runs with FSO as default layout.

https://issues.apache.org/jira/browse/HDDS-16090

How was this patch tested?

Before:

[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 71.28 s -- in org.apache.hadoop.ozone.shell.TestOzoneShellHA
[INFO] Tests run: 35, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 112.7 s -- in org.apache.hadoop.ozone.shell.TestOzoneShellHAWithFollowerRead
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 69.72 s -- in org.apache.hadoop.ozone.shell.TestOzoneShellHAWithFSO

After:

[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 106.7 s -- in org.apache.hadoop.ozone.shell.TestOzoneShellHA
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.41 s -- in org.apache.hadoop.ozone.shell.TestOzoneShellHA
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.15 s -- in org.apache.hadoop.ozone.shell.TestOzoneShellHAWithFollowerRead

https://github.com/adoroszlai/ozone/actions/runs/30988165814

@adoroszlai adoroszlai added the test label Aug 5, 2026
@adoroszlai adoroszlai self-assigned this Aug 5, 2026
@adoroszlai
adoroszlai requested a review from ivandika3 August 5, 2026 09:34

@ivandika3 ivandika3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for the improvement, LGTM +1.

@adoroszlai
adoroszlai merged commit ac4278a into apache:master Aug 6, 2026
30 of 32 checks passed
@adoroszlai
adoroszlai deleted the HDDS-16090 branch August 6, 2026 05:25
@adoroszlai

Copy link
Copy Markdown
Contributor Author

Thanks @ivandika3 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants