Skip to content

HDDS-4129. change MAX_QUOTA_IN_BYTES to Long.MAX_VALUE. #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenSammi merged 5 commits into from
Sep 11, 2020
Merged

HDDS-4129. change MAX_QUOTA_IN_BYTES to Long.MAX_VALUE. #1337

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e8f4f6
change max quota in bytes to long max value.
captainzmc Aug 19, 2020
daae0e2
initialize old volume quota.
captainzmc Sep 4, 2020
c955f26
fix review issues.
captainzmc Sep 4, 2020
a64e251
Revert "fix review issues."
captainzmc Sep 10, 2020
1613758
Revert "initialize old volume quota."
captainzmc Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,9 @@ public static Versioning getVersioning(boolean versioning) {


/**
* Max OM Quota size of 1024 PB.
* Max OM Quota size of Long.MAX_VALUE.
*/
public static final long MAX_QUOTA_IN_BYTES = 1024L * 1024 * TB;
public static final long MAX_QUOTA_IN_BYTES = Long.MAX_VALUE;

@adoroszlai adoroszlai Aug 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about volumes created before this change with the previous max. value? Will those be treated by new version as if quota had been enabled for them?

@captainzmc captainzmc Aug 25, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @adoroszlai 's discussion. Yes, the previous volume will enable quota. So I created JIRA HDDS-4106, which supports user Clearing spaceQuota.

@ChenSammi ChenSammi Aug 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest add new logic during OM startup to reset existing Volume max quota value to mitigate the compatibility issue.

@ChenSammi ChenSammi Aug 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked HDFS implementation，it doesn't use LONG.MAX_VALUE to verify whether quota is enabled or not. It use "-1" which is more reasonable for a set/unset check.

@captainzmc captainzmc Aug 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sammi for the discussion. It is indeed uncommon to use the maximum value to determine whether to enable quota, and it is more common to use -1 to determine. Later I will confirm whether to enable quota with -1 in HDDS-3727. The MAX_QUOTA_IN_BYTES here will be used to determine if the parameter values for setquota and updatequota are reasonable in HDDS-3725.


/**
* Quota RESET default is -1, which means quota is not set.
Expand Down