Fix excldue typo in apache-rat exclude patterns - #7028
Merged
Merged
Conversation
Maven ignores unknown excldue, so **/*.MD was never excluded. Fixes part of apache#6603.
This was referenced Sep 3, 2026
Aias00
approved these changes
Sep 3, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Summary
Trivial but correct fix: <excldue> → <exclude> in the Apache RAT license-check plugin configuration, in both the root pom.xml and shenyu-e2e/pom.xml.
What is correct
- Maven silently ignores unknown configuration tags, so the original
<excldue>**/*.MD</excldue>was a no-op —**/*.MDfiles were never excluded from RAT license checks. Restoring<exclude>makes the intended exclusion effective again. - Change is purely declarative (POM exclude tags); no runtime/compiled-behavior change, no functional risk.
- Scope is intentionally small (the author explicitly left the CI
rat:checkenablement out), which keeps this a safe, low-risk diff.
Verdict
Approve. No blocking issues.
Non-blocking suggestions
- Consider following up in #6603 with the actual
rat:checkCI enablement so the typo can't silently regress again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed
<excldue>→<exclude>in the apache-rat plugin config inpom.xmlandshenyu-e2e/pom.xml.Maven silently ignores unknown tags, so
**/*.MDwas never excluded from license checks.Why
Part of #6603 — this PR only fixes the typo; I left the CI verify/rat:check change out so this stays a small, safe diff.
Test
Diff-only change to POM exclude tags; no runtime behavior change.