refactor(composer): cleanup and normalize composer.json - #3792
Open
nortej-hash wants to merge 2 commits into
Open
refactor(composer): cleanup and normalize composer.json#3792nortej-hash wants to merge 2 commits into
nortej-hash wants to merge 2 commits into
Conversation
Member
Code reviewFound 3 issues:
Lines 7 to 9 in b8da62a
Lines 58 to 60 in b8da62a
Lines 12 to 14 in b8da62a Each is harmless on its own. The ask is to either restore them or name them in the PR description, so that a reformat PR reviews as a reformat. The 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
The reformat also removed three keys. "readme": "README.md" and "minimum-stability": "stable" were both set deliberately in 384647d when the PHP package was made release-ready, and authors[0].homepage has been there since the file was first added. None of the three changes behaviour -- Packagist auto-detects README.md for GitHub-hosted packages, and stable is Composer's default -- but a reformat should not drop them silently. Also adds the trailing newline that .editorconfig requires for every file via insert_final_newline, and which the rewrite left off. composer.json is now semantically identical to the one on master except for the http -> https homepage update this PR already made, which the author block now follows as well. composer validate passes. Client: php Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
|
@sveneld Could you have a look from your side and merge if all is fine? |
Contributor
|
I’ll look at it over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]anywhere in the commit message to free up build resources.