Fix Proxy-Protocol log field symbols - #13345
Merged
Merged
Conversation
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jul 6, 2026
(cherry picked from commit 7772518)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Log::init_fields()registered the Proxy Protocol source/destination IP logfields into
field_symbol_hashunderppsip/ppdip, but theLogFields(and the documentation) use the symbols
pps/ppd. This aligns the hash keyswith the actual symbols.
Why this is not a critical bug
Obviously this is a bug, but logging output was not broken. Because
LogFieldList::find_by_symbol()falls back to a linear scan by symbol on ahash miss, so
%<pps>/%<ppd>still resolved correctly.The mismatch only meant:
slower fallback instead),
ppsip/ppdipaliases were silently accepted, andTSLogFieldRegister()couldmis-handle the
pps/ppdsymbols.Note: formats that relied on the bogus
ppsip/ppdipaliases will now berejected as unknown symbols; use the documented
pps/ppd.