Fix exact URL cache config matching - #13438
Merged
Merged
Conversation
maskit
previously approved these changes
Jul 31, 2026
Member
|
Please resolve the merge conflict. |
bneradt
force-pushed
the
fix-exact-url-cache-config
branch
from
July 31, 2026 22:10
428d3a4 to
ab4a364
Compare
Exact URL entries in cache.config are dropped after successful parsing, so their cache actions never apply. Failed entries are inserted instead, which also defeats duplicate detection. Correct the success check and add unit and replay coverage for matching, nonmatching, invalid, and duplicate rules. Extend ATSReplayTest to accept cache.config entries with dynamic server ports. Fixes: apache#13421
bneradt
force-pushed
the
fix-exact-url-cache-config
branch
from
July 31, 2026 22:16
ab4a364 to
8b40074
Compare
maskit
approved these changes
Jul 31, 2026
cmcfarlen
pushed a commit
that referenced
this pull request
Aug 4, 2026
Exact URL entries in cache.config are dropped after successful parsing, so their cache actions never apply. Failed entries are inserted instead, which also defeats duplicate detection. Correct the success check and add unit and replay coverage for matching, nonmatching, invalid, and duplicate rules. Extend ATSReplayTest to accept cache.config entries with dynamic server ports. Fixes: #13421 (cherry picked from commit d05506e)
Contributor
|
Cherry-picked to the 10.2.x branch as 92f3f3c for the 10.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact
url=entries incache.configare currently inserted only when record initialization fails. Successfully parsed rules are silently dropped, so their cache actions never apply, while failed rules incorrectly advance matcher state.Correct the success check, add focused
UrlMatcherunit coverage, and add an exact-URL replay AuTest. The replay helper now acceptscache_configentries with dynamic server ports so this behavior can be tested end to end.Testing:
cache-exact-urlfails withexpected 201 got 200test_proxy "[ControlMatcher]"passes 13 assertionscache-exact-urlpassesFixes #13421