Guard quiche-only QUIC connection state - #13478
Merged
Merged
Conversation
Native OpenSSL QUIC builds do not use the connection table or quiche timeout event stored by QUICNetVConnection. Clang diagnoses those quiche-only private fields as unused, causing warnings-as-errors builds to fail. This guards the members with TS_HAS_QUICHE so native OpenSSL builds do not declare them while quiche builds retain the required state.
cmcfarlen
approved these changes
Aug 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Guards quiche-only QUIC connection state in QUICNetVConnection so OpenSSL QUIC builds don’t declare unused private fields (avoiding -Werror failures), while keeping required state for quiche builds.
Changes:
- Wrap
_ctablemember in#if TS_HAS_QUICHE. - Wrap
_quiche_timeoutmember in#if TS_HAS_QUICHE. - Minor formatting normalization around quiche-timeout method declarations.
cmcfarlen
pushed a commit
that referenced
this pull request
Aug 4, 2026
Native OpenSSL QUIC builds do not use the connection table or quiche timeout event stored by QUICNetVConnection. Clang diagnoses those quiche-only private fields as unused, causing warnings-as-errors builds to fail. This guards the members with TS_HAS_QUICHE so native OpenSSL builds do not declare them while quiche builds retain the required state. (cherry picked from commit 5d878a4)
Contributor
|
Cherry-picked to the 10.2.x branch as c4595b2 for the 10.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native OpenSSL QUIC builds do not use the connection table or quiche
timeout event stored by QUICNetVConnection. Clang diagnoses those
quiche-only private fields as unused, causing warnings-as-errors builds
to fail.
This guards the members with TS_HAS_QUICHE so native OpenSSL builds do
not declare them while quiche builds retain the required state.