Fix wrong variable in eventloop events max metric - #13488
Merged
Conversation
Slice::record_event_count() assigned the loop-execution count instead of the event count, so proxy.process.eventloop.events.max.* has always reported how many loops ran rather than the largest number of events dispatched in a single loop.
moonchen
added
Event System
Backport
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Fixes the eventloop “events max” metric to reflect the number of events processed (not iteration count), correcting proxy.process.eventloop.events.max.* reporting.
Changes:
- Update
record_event_countto store_events._maxfrom thecountargument instead of_count.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Aug 5, 2026
Slice::record_event_count() assigned the loop-execution count instead of the event count, so proxy.process.eventloop.events.max.* has always reported how many loops ran rather than the largest number of events dispatched in a single loop. (cherry picked from commit a2ff4ae)
Contributor
|
Cherry-picked to the 10.2.x branch as 0f07a58 for the 10.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for counting eventloop events max used the incorrect
_countvariable, which stores the number of iterations, rather than the number of events.proxy.process.eventloop.events.max.*has therefore been reporting an iteration count. Fix it by changing the code to usecount.