Fix bad return in validate_hostname - #13498
Merged
Merged
Conversation
The function has a `bool` return type, but returned `-1` to indicate an error on UTF-8 conversion failure. This patch corrects the return statement to return `false`.
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Fixes validate_hostname returning an invalid value (-1) despite having a bool return type, ensuring UTF-8 conversion failures correctly return false.
Changes:
- Replaces
return -1;withreturn false;whenASN1_STRING_to_UTF8fails.
Contributor
Author
|
[approve ci autest 0] |
bneradt
approved these changes
Aug 5, 2026
maskit
approved these changes
Aug 5, 2026
cmcfarlen
pushed a commit
that referenced
this pull request
Aug 6, 2026
The function has a `bool` return type, but returned `-1` to indicate an error on UTF-8 conversion failure. This patch corrects the return statement to return `false`. (cherry picked from commit d70bdb7)
Contributor
|
Cherry-picked to the 10.2.x branch as 79861fb for the 10.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function has a
boolreturn type, but returned-1to indicate an error on UTF-8 conversion failure. This patch corrects the return statement to returnfalse.