Skip rate_limit AuTests when plugin not built - #13589
Merged
Merged
Conversation
The rate_limit plugin is experimental at this time and not guaranteed to be in the build. Most of the rate_limit AuTests already handle this appropriately, but a few were missing the `SkipUnless` directive.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the experimental rate_limit plugin AuTests are skipped when the plugin binary isn’t present in the build, avoiding spurious CI failures when experimental plugins are not compiled/installed.
Changes:
- Added
Test.SkipUnless(Condition.PluginExists('rate_limit.so'))guards to rate_limit AuTests that previously assumed the plugin was built.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/gold_tests/pluginTest/rate_limit/rate_limit.test.py | Skip the test unless rate_limit.so exists. |
| tests/gold_tests/pluginTest/rate_limit/rate_limit_sni.test.py | Skip the test unless rate_limit.so exists. |
| tests/gold_tests/pluginTest/rate_limit/rate_limit_iprep.test.py | Skip the test unless rate_limit.so exists. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bneradt
approved these changes
Aug 26, 2026
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Sep 9, 2026
The rate_limit plugin is experimental at this time and not guaranteed to be in the build. Most of the rate_limit AuTests already handle this appropriately, but a few were missing the `SkipUnless` directive. (cherry picked from commit e23cede)
Contributor
|
Cherry-picked to the 10.2.x branch as d2a2162 for the 10.2.1 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rate_limit plugin is experimental at this time and not guaranteed to be in the build. Most of the rate_limit AuTests already handle this appropriately, but a few were missing the
SkipUnlessdirective.