Traffic Dump: fix client request target parsing - #6414
Merged
Conversation
bneradt
force-pushed
the
traffic_dump_url_fix
branch
from
February 11, 2020 23:47
cad8146 to
03ffd37
Compare
bneradt
force-pushed
the
traffic_dump_url_fix
branch
from
February 24, 2020 19:21
03ffd37 to
193df62
Compare
Before this change, traffic_dump included the remapped URL in the request target put into the client-request field, even if the client's request had no such URL in the target. This fixes things so that the URL field is accurate with respect to the original request. There's a couple other minor tweaks: * Format UUID as an "all" headers field. * start-time -> connection-time, per Proxy Verifier's expectations.
bneradt
force-pushed
the
traffic_dump_url_fix
branch
from
February 24, 2020 22:09
193df62 to
1335d5b
Compare
SolidWallOfCode
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, traffic_dump included the remapped URL in the
request target put into the client-request field, even if the
client's request had no such URL in the target. This fixes things so
that the URL field is accurate with respect to the original request.