Skip to content

[Hexagon] Tighten requirements on inclusion of runtime sources #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kparzysz-quic merged 3 commits into from
Jun 13, 2022
Merged

[Hexagon] Tighten requirements on inclusion of runtime sources #11635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed4cfdb
Tighten requirements on when Hexagon runtime sources
csullivan Jun 6, 2022
2f435a8
Remove device_api.cpu binding to hexagon in simulator rpc session.
csullivan Jun 8, 2022
2b25ae8
if(BUILD_FOR_HEXAGON)
adstraw Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/modules/Hexagon.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
endfunction()

if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
if(BUILD_FOR_HEXAGON)
# Common sources for TVM runtime with Hexagon support
file_glob_append(RUNTIME_HEXAGON_SRCS
"${TVMRT_SOURCE_DIR}/hexagon/*.cc"
Expand Down
4 changes: 0 additions & 4 deletions src/runtime/hexagon/rpc/simulator/session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,10 +568,6 @@ detail::Optional<HEXAPI_Cpu> SimulatorRPCChannel::GetCPU(const detail::MaybeStri
}

SimulatorRPCChannel::SimulatorRPCChannel(int stack_size, std::string args) {
const auto* api = tvm::runtime::Registry::Get("device_api.hexagon");
ICHECK(api != nullptr);
tvm::runtime::Registry::Register("device_api.cpu", true).set_body(*api);

const char* sdk_root_env = std::getenv("HEXAGON_SDK_ROOT");
ICHECK(sdk_root_env != nullptr) << "Please set HEXAGON_SDK_ROOT";
const char* toolchain_env = std::getenv("HEXAGON_TOOLCHAIN");
Expand Down