Skip to content

[TVMC] Add tvmc flag to print ir before and print ir after named pass - #16261

Merged
lhutton1 merged 6 commits into
apache:mainfrom
eirenevp:tvmc-print-ir-option
Jan 11, 2024
Merged

[TVMC] Add tvmc flag to print ir before and print ir after named pass #16261
lhutton1 merged 6 commits into
apache:mainfrom
eirenevp:tvmc-print-ir-option

Conversation

@eirenevp

@eirenevp eirenevp commented Dec 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Add --print-ir-before and --print-ir-after options to print IR before and after a named pass from the compiler's command line driver.

@eirenevp eirenevp changed the title Add tvmc flag to print ir before / after pass names. Add tvmc flag to print ir before / after pass names Dec 18, 2023
@eirenevp
eirenevp force-pushed the tvmc-print-ir-option branch 2 times, most recently from ee872b7 to fe5bdc4 Compare December 18, 2023 17:36
@eirenevp eirenevp changed the title Add tvmc flag to print ir before / after pass names [TVMC] Add tvmc flag to print ir before / after pass names Dec 18, 2023
@eirenevp eirenevp changed the title [TVMC] Add tvmc flag to print ir before / after pass names [TVMC] Add tvmc flag to print ir before / after named pass Dec 18, 2023
@lhutton1

lhutton1 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

@tvm-bot rerun

@eirenevp eirenevp changed the title [TVMC] Add tvmc flag to print ir before / after named pass [TVMC] Add tvmc flag to print ir before and print ir after named pass Dec 18, 2023
@eirenevp
eirenevp force-pushed the tvmc-print-ir-option branch from fe5bdc4 to 6cbc66a Compare December 19, 2023 11:59
ekalda
ekalda requested changes Dec 20, 2023
View reviewed changes

@ekalda ekalda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eirenevp! Looks mostly good, some comments...

Comment thread python/tvm/driver/tvmc/compiler.py Outdated
Comment thread python/tvm/ir/instrument.py Outdated
Comment thread python/tvm/ir/instrument.py Outdated
Comment thread tests/python/driver/tvmc/test_command_line.py Outdated
Comment thread tests/python/driver/tvmc/test_command_line.py Outdated
Comment thread tests/python/driver/tvmc/test_command_line.py
Comment thread python/tvm/ir/instrument.py Outdated
ekalda
ekalda reviewed Dec 27, 2023
View reviewed changes

@ekalda ekalda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! One more suggestion...

Comment thread python/tvm/driver/tvmc/compiler.py Outdated
lhutton1
lhutton1 reviewed Jan 5, 2024
View reviewed changes

@lhutton1 lhutton1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eirenevp, this will be a great step to improving debuggability! I noticed a couple of things, otherwise LGTM!

Comment thread python/tvm/ir/instrument.py Outdated
Comment thread python/tvm/ir/instrument.py Outdated
ekalda
ekalda approved these changes Jan 8, 2024
View reviewed changes

@ekalda ekalda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eirenevp, nice work! :)

@lhutton1

lhutton1 commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

@tvm-bot rerun

@lhutton1
lhutton1 merged commit 8e67e2a into apache:main Jan 11, 2024
@lhutton1

lhutton1 commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

Thanks @eirenevp @ekalda!

@ysh329 ysh329 mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekalda ekalda ekalda approved these changes
@lhutton1 lhutton1 lhutton1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eirenevp @lhutton1 @ekalda