Conversation
junrushao
reviewed
Jan 7, 2024
Member
|
Thanks for the fix. Beyond this commits, should we also check the |
This PR adds a sanity check to ensure that all `tir_var_upper_bound` attrs used by static memory planning has integer as value type. This check helps avoid mistakes of using wrong value types. The check is needed since `func->GetAttr<Map<String, IntImm>>` does not apply type check.
MasterJH5574
force-pushed
the
unity-dev/2024-01-07-mem-plan-type-check
branch
from
January 8, 2024 17:19
fb1b236 to
64f66c1
Compare
Contributor
Author
|
Thanks @junrushao and @Hzfengsy for the suggestions! Just updated the PR. Please take another look at your convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sanity check to ensure that all
tir_var_upper_boundattrs used by static memory planning has integer as value type. This check helps avoid mistakes of using wrong value types.The check is needed since
func->GetAttr<Map<String, IntImm>>does not apply type check.