Skip to content

[Relay][Frontend][Torch] fix a typo mistake in nonzero_numpy #16390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
Jan 12, 2024
Merged

[Relay][Frontend][Torch] fix a typo mistake in nonzero_numpy #16390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/relay/frontend/pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2680,7 +2680,7 @@ def nonzero(self, inputs, input_types, is_numpy_style=False):
return ret

def nonzero_numpy(self, inputs, input_types):
return self.nonzero(inputs, input_types, is_numpy_style=False)
return self.nonzero(inputs, input_types, is_numpy_style=True)

@t-vi t-vi Jan 12, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!


def scatter(self, inputs, input_types):
assert len(inputs) == 4 or len(inputs) == 5, (
Expand Down
1 change: 1 addition & 0 deletions tests/python/frontend/pytorch/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4445,6 +4445,7 @@ def forward(self, data):

inp = torch.Tensor(np.array([[0, 1, 0], [2, 0, 9], [-1, -1, 0]]).astype("float32"))
verify_trace_model(Nonzero(), [inp], ["llvm"])
verify_trace_model(Nonzero(as_tuple=True), [inp], ["llvm"])


def test_forward_scatter():
Expand Down