[Unity] Improved error message in tvm::relax::UpdateStructInfo - #16472
Merged
slyubomirsky merged 1 commit intoJan 26, 2024
Merged
slyubomirsky merged 1 commit into
slyubomirsky merged 1 commit into
Conversation
If the struct info cannot be updated, provide the expression, the previous struct info, and the new struct info in the error message.
slyubomirsky
approved these changes
Jan 26, 2024
slyubomirsky
left a comment
slyubomirsky
left a comment
Contributor
There was a problem hiding this comment.
Thanks! It's a handy improvement.
Contributor
Author
|
Thank you! Any time that I need more information for debugging, I try to add it to the error message so that it’s easier the next time around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the struct info cannot be updated, provide the expression, the previous struct info, and the new struct info in the error message.