[Bugfix][Relax] Remove call to tvm.build for empty TIR module - #16561
Merged
Lunderberg merged 1 commit intoFeb 14, 2024
Merged
Conversation
Prior to this commit, if a lowered `IRModule` does not contain any TIR functions, `tvm.relax.build` provided an empty `tir_mod`, which caused a segfault during TIR compilation. This could occur when `tvm.relax.build` is called without an explicit target argument, for a module that does not define any virtual devices. This commit updates the `_filter_tir` utility function to return `None` if there are no TIR functions, rather than an empty `IRModule`. In addition, checks for an empty `IRModule` are added to `tvm.build` and `TIRToRuntime`, so that a similar failure mode would raise an exception rather than producing a segfault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a lowered
IRModuledoes not contain any TIR functions,tvm.relax.buildprovided an emptytir_mod, which caused a segfault during TIR compilation. This could occur whentvm.relax.buildis called without an explicit target argument, for a module that does not define any virtual devices.This commit updates the
_filter_tirutility function to returnNoneif there are no TIR functions, rather than an emptyIRModule. In addition, checks for an emptyIRModuleare added totvm.buildandTIRToRuntime, so that a similar failure mode would raise an exception rather than producing a segfault.