[Relax] Additional unit tests for RemoveUnusedParameters - #16574
Merged
Lunderberg merged 2 commits intoFeb 23, 2024
Merged
Conversation
Verifying behavior for subroutines that receive `R.Prim` or `R.Shape` parameters, if the symbolic variables defined by those parameters are already defined by another parameter.
Contributor
Author
|
This test case was written to verify the statements I made in this comment. Adding them to the CI, as it was behavior of |
| class TestRemoveExtraShapeVariables(BaseCompare): | ||
| """Remove parameters that only serve to define existing symbolic variables | ||
|
|
||
| If a `R.Shape` parameter provies a definition of a symbolic |
Contributor
There was a problem hiding this comment.
Suggested change
| If a `R.Shape` parameter provies a definition of a symbolic | |
| If a `R.Shape` parameter provides a definition of a symbolic |
typo 😜
Contributor
Author
There was a problem hiding this comment.
Thank you, and fixed!
slyubomirsky
approved these changes
Feb 22, 2024
slyubomirsky
left a comment
slyubomirsky
left a comment
Contributor
There was a problem hiding this comment.
Nice to have more tests, and thank you for including explanations of what the test cases demonstrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying behavior for subroutines that receive
R.PrimorR.Shapeparameters, if the symbolic variables defined by those parameters are already defined by another parameter.