Skip to content

[Relay][ONNX] Fix the attribute mode parse of operator Upsample #16622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echuraev merged 4 commits into from
Feb 23, 2024
Merged

[Relay][ONNX] Fix the attribute mode parse of operator Upsample #16622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c356287
add the default value for mode attrbute of Upsample
jikechao Feb 22, 2024
b997ae1
Update test_forward.py
jikechao Feb 22, 2024
d7cdb70
Update onnx.py
jikechao Feb 22, 2024
5c65e77
Update test_forward.py
jikechao Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/relay/frontend/onnx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,7 +2392,7 @@ def _impl_v9(cls, inputs, attr, params):
if not isinstance(scales, _expr.Expr):
assert scales[0] == 1.0 and scales[1] == 1.0

mode = attr.get("mode")
mode = attr.get("mode", b"nearest")
if mode == b"nearest":
method = "nearest_neighbor"
elif mode == b"linear":
Expand Down
22 changes: 22 additions & 0 deletions tests/python/frontend/onnx/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1726,6 +1726,27 @@ def test_upsample_nearest(target, dev):
verify_with_ort_with_inputs(model, [in_array], [out_shape], opset=7, target=target, dev=dev)


@tvm.testing.parametrize_targets
def test_upsample_nearest_default(target, dev):
"""test_upsample_nearest_default"""
scale = 2
in_shape = (1, 1, 3, 3)
out_shape = (1, 1, 3 * scale, 3 * scale)
y = helper.make_node("Upsample", ["in"], ["out"], scales=[1.0, 1.0, 2.0, 2.0])

in_array = np.random.uniform(size=in_shape).astype(np.float32)

graph = helper.make_graph(
[y],
"upsample_nearest_test",
inputs=[helper.make_tensor_value_info("in", TensorProto.FLOAT, list(in_shape))],
outputs=[helper.make_tensor_value_info("out", TensorProto.FLOAT, list(out_shape))],
)

model = helper.make_model(graph, producer_name="upsample_nearest_test")
verify_with_ort_with_inputs(model, [in_array], [out_shape], opset=7, target=target, dev=dev)


@tvm.testing.parametrize_targets
def test_upsample3d_nearest(target, dev):
"""test_upsample3d_nearest"""
Expand Down Expand Up @@ -5707,6 +5728,7 @@ def verify_eyelike(indata, dynamic=False):
"test_unique_sorted_with_axis_3d",
"test_unique_sorted_with_negative_axis",
"test_upsample_nearest",
"test_upsample_nearest_default",
]


Expand Down