[Web] Support web indexDB cache for larger model storage - #16733
Merged
Merged
Conversation
DiegoCao
marked this pull request as ready for review
March 20, 2024 16:17
DiegoCao
changed the title
CharlieFRuan
left a comment
CharlieFRuan
left a comment
Member
There was a problem hiding this comment.
Thank you! Tested with WebLLM and it is able to download and retrieve with IndexedDB. There are some items below we should address before merging it.
DiegoCao
force-pushed
the
main
branch
2 times, most recently
from
April 1, 2024 17:19
8af42af to
1ed3223
Compare
Member
|
Thank you for the updates! I will review soon today/tomorrow. |
- We make addToCache not return anything, see new specification - This allows us to skip downloaded files in fetchNDArrayCache instead of running into DOMException: Key already exists - Call addToCache in fetchWithCache, so we only need to retrieve afterwards - Remove cacheOnly for callback, use loading instead (since we separated download and loading) - Fix responseTostoretype bug in ArtifactCache
Contributor
|
@tvm-bot rerun |
tqchen
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support IndexDB Cache, including the following:
One change to use the IndexDBCache is, as there's no json() response when calling fetchCacheData, thinking about removing the .json() when calling fetchCacheData. @CharlieFRuan