[Fix] Lazy import of "psutil" in disco process pool - #16752
Merged
tqchen merged 1 commit intoMar 20, 2024
Merged
Conversation
Prior to this PR, module "psutil" is imported at the top level of the disco process pool. The pool will try to kill all the processes at the time of destruction (when `__del__` is implicitly invoked). The `__del__` function eventually calls into a function that uses `pstuil`. But it is possible that the top-level `psutil` has already been released by Python, which leads to a KeyError as follows: ``` Exception ignored in: <function DiscoPopenWorker.__del__ at 0x7f2c922bfe20> Traceback (most recent call last): File "/home/ruihangl/Workspace/tvm/python/tvm/runtime/disco/process_pool.py", line 67, in __del__ File "/home/ruihangl/Workspace/tvm/python/tvm/runtime/disco/process_pool.py", line 81, in kill File "/home/ruihangl/Workspace/tvm/python/tvm/runtime/disco/process_pool.py", line 162, in _kill_child_processes File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/__init__.py", line 323, in __init__ File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/__init__.py", line 353, in _init File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/_pslinux.py", line 1738, in __init__ File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/_common.py", line 864, in get_procfs_path KeyError: 'psutil' ``` This PR fixes the issue by lazily importing `psutil` when needed.
tqchen
approved these changes
Mar 20, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
Prior to this PR, module "psutil" is imported at the top level of the disco process pool. The pool will try to kill all the processes at the time of destruction (when `__del__` is implicitly invoked). The `__del__` function eventually calls into a function that uses `pstuil`. But it is possible that the top-level `psutil` has already been released by Python, which leads to a KeyError as follows: ``` Exception ignored in: <function DiscoPopenWorker.__del__ at 0x7f2c922bfe20> Traceback (most recent call last): File "/home/ruihangl/Workspace/tvm/python/tvm/runtime/disco/process_pool.py", line 67, in __del__ File "/home/ruihangl/Workspace/tvm/python/tvm/runtime/disco/process_pool.py", line 81, in kill File "/home/ruihangl/Workspace/tvm/python/tvm/runtime/disco/process_pool.py", line 162, in _kill_child_processes File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/__init__.py", line 323, in __init__ File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/__init__.py", line 353, in _init File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/_pslinux.py", line 1738, in __init__ File "/home/ruihangl/Workspace/miniconda3/envs/python311/lib/python3.11/site-packages/psutil/_common.py", line 864, in get_procfs_path KeyError: 'psutil' ``` This PR fixes the issue by lazily importing `psutil` when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, module "psutil" is imported at the top level of the disco process pool. The pool will try to kill all the processes at the time of destruction (when
__del__is implicitly invoked). The__del__function eventually calls into a function that usespstuil. But it is possible that the top-levelpsutilhas already been released by Python, which leads to a KeyError as follows:This PR fixes the issue by lazily importing
psutilwhen needed.